andygrove opened a new issue, #5641: URL: https://github.com/apache/datafusion-comet/issues/5641
### Describe the bug `docs/source/user-guide/latest/iceberg-writes.md` still describes the native writer as future work. The "Native Parquet write eligibility" section says: > A planned follow-up (#5308) replaces the `IcebergWrite` operator's per-task Parquet write with iceberg-rust. ... with the current release the native writer itself is not yet wired in, so every write still runs through iceberg-java and the check's outcome is reported as a fall-back reason #5308 closed when #5361 merged, so with `spark.comet.iceberg.write.enabled=true` an eligible write now runs through iceberg-rust. The doc's overview and configuration sections were updated in #5361 but this paragraph was not, and the two now contradict each other. Two smaller items in the same page: - The accepted-divergences list says partition paths are not URL-escaped. That divergence goes away once #5636 bumps the iceberg-rust pin, and the entry should move to a "fixed upstream" note or be deleted at that point. - The metrics-mode paragraph says the `counts` / `none` restrictions "remain only until that assembly lands". The JVM-side metrics assembly landed in #5361; whether the restriction can be lifted is tracked separately (see the metrics-mode issue linked from the epic), and the doc should point at that issue rather than describe it as pending. ### Steps to reproduce Read the "Native Parquet write eligibility" section of `iceberg-writes.md` on `main`. ### Expected behavior The section describes the shipped behavior: eligibility gates the native write, ineligible writes fall back with a reason, and nothing implies the writer is unimplemented. ### Additional context Part of the native Iceberg writes epic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
