gene-bordegaray commented on code in PR #24670:
URL: https://github.com/apache/datafusion/pull/24670#discussion_r3927657601
##########
datafusion/physical-plan/src/projection.rs:
##########
@@ -83,6 +83,9 @@ pub struct ProjectionExec {
metrics: ExecutionPlanMetricsSet,
/// Cache holding plan properties like equivalences, output partitioning
etc.
cache: Arc<PlanProperties>,
+ /// Whether the output metadata differs from the metadata derived from the
+ /// projection expressions and input schema.
+ overrides_metadata: bool,
Review Comment:
I believe this actually wont happen because in our `replace_children`
implementation:
- on a `Keep` we clone this value with is ok because we are saying the child
will have the same `PlanProterties` as the old child
- on a `Recompute` we do pass the new input schema to
`compute_overrides_metadata` and recompute the flag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
