alamb commented on issue #2453: URL: https://github.com/apache/datafusion-sqlparser-rs/issues/2453#issuecomment-5526221068
Here is a review of open PRs / issues that look like bug or regression fixes (rather than new features) worth considering for this release. Note: none of these PRs have been reviewed/approved yet, so the bottleneck is committer review time. ## Stack-overflow / panic protection (highest priority) - [ ] https://github.com/apache/datafusion-sqlparser-rs/pull/2411 — Add recursion checks for `parse_data_type`; nested `MAP<MAP<...>>` can overflow the stack. - [ ] https://github.com/apache/datafusion-sqlparser-rs/pull/2465 — Apply recursion limit without std; the recursion limit was a silent no-op in `no_std` builds. - [ ] https://github.com/apache/datafusion-sqlparser-rs/pull/2440 — Close the remaining gaps in the parser recursion counter. - [ ] https://github.com/apache/datafusion-sqlparser-rs/pull/2400 — Apply recursive-protection to the `Spanned::span` walk. ## Round-trip bugs (parse → display → output that fails to reparse or means something else) - [ ] https://github.com/apache/datafusion-sqlparser-rs/pull/2464 — Preserve single quote literal display; `''''''` loses a level of escaping, changing the string's meaning. - [ ] https://github.com/apache/datafusion-sqlparser-rs/pull/2423 — MySQL: print a space before `PARTITION` when displaying a table factor; round-trips to `employeesPARTITION (p0)`, which reparses as a table function. - [ ] https://github.com/apache/datafusion-sqlparser-rs/pull/2424 — Print a space between adjacent prefix unary operators; `~ ~ 1` prints as `~~1`. - [ ] https://github.com/apache/datafusion-sqlparser-rs/pull/2418 — Escape closing brackets in bracket-quoted identifiers; fixes https://github.com/apache/datafusion-sqlparser-rs/issues/2409. - [ ] https://github.com/apache/datafusion-sqlparser-rs/pull/2463 — Preserve numeric compound field access display; `CASE ... END . 2` prints as unparseable `END.2`. - [ ] https://github.com/apache/datafusion-sqlparser-rs/pull/2395 — Fix Hive `SKEWED BY` display; fixes https://github.com/apache/datafusion-sqlparser-rs/issues/1499. ## Regressions and precedence bugs - [ ] https://github.com/apache/datafusion-sqlparser-rs/pull/2398 — Allow `TOP` as an identifier when not a row-limit clause; fixes https://github.com/apache/datafusion-sqlparser-rs/issues/2046, related to regression report https://github.com/apache/datafusion-sqlparser-rs/issues/2049. - [ ] https://github.com/apache/datafusion-sqlparser-rs/pull/2471 — Honour operator precedence in MySQL and Spark `DIV`; fixes https://github.com/apache/datafusion-sqlparser-rs/issues/2460. - [ ] https://github.com/apache/datafusion-sqlparser-rs/issues/2461 and https://github.com/apache/datafusion-sqlparser-rs/issues/2462 — `&` / `->` / `->>` precedence inconsistencies across dialects; open issues with **no PR yet**. ## Visitor correctness (matters for DataFusion and other AST consumers) - [ ] https://github.com/apache/datafusion-sqlparser-rs/pull/2477 — Visit function clauses in source order. - [ ] https://github.com/apache/datafusion-sqlparser-rs/pull/2442 — Visit `CreateView` name as a relation. The remaining open PRs are dialect feature additions (Snowflake EXTERNAL VOLUME, Databricks syntax, CREATE RULE, Doris dialect, etc.) which can likely wait for `0.64.0`. *This list was compiled with the assistance of Claude* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
