theirix opened a new pull request, #24934: URL: https://github.com/apache/datafusion/pull/24934
## Which issue does this PR close? - Closes #23835. ## Rationale for this change Provide full precision for decimals in SLT tests. Separate float formatting (round to 12/15 digits) from decimal formatting (avoid rounding) ## What changes are included in this PR? - For floats, round to 12 digits by default and 15 for Spark (historically), via a generic function - For decimals, avoid rounding entirely. Emit any trailing zeroes to SLT output, as they are part of decimals. Rely on `format_decimal` directly - For Postgres mode with `decimal_to_str` - emit BigDecimal representation of numerics directly - Remove `big_decimal_to_str` helper with rounding behaviour - Refines #23160 - CC @AdamGS ## What is the testing strategy for this PR? - An SLT test case for the issue - now it produces the expected decimal with full precision - Reworked unit tests to test float and decimal conversion, but not an intermediate `big_decimal_to_str` - Regenerated SLTs with `--complete` to introduce trailing zeroes - a huge inevitable change ## Are there any user-facing changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
