peterxcli commented on PR #4727: URL: https://github.com/apache/datafusion-comet/pull/4727#issuecomment-5536600048
Addressed in 1c7b9d304: - Invalid collect decoder configuration/state now returns an error instead of silently falling through. Nested Unsafe buffers are bounds-checked before pointer-based reads, with malformed and null-state tests. - Audited the relevant Spark 3.4.3 through 4.2.0 serialization layouts and documented the result in the PR description. - Merged current upstream main, resolving the source and Spark patch filename conflicts. - Documented the landing order: #4727 first, then #5421/#5420 rebase and preserve the supported Spark Partial -> Comet PartialMerge collect boundary. Local validation passed: 4 focused Rust decoder tests, `make core`, 2 focused `CometAggregateSuite` tests, and 4 SQL-file runs covering both collect functions and Parquet dictionary modes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
