Visorgood commented on PR #5558: URL: https://github.com/apache/datafusion-comet/pull/5558#issuecomment-5538704075
Thanks @sunchao! I confirmed the mechanism: `CaseExpr::try_new` normalizes a null-literal `else_expr` to `None`, which takes the single-filter-plus-scatter path instead of materializing both branches. The swap is semantically exact, so this looks well worth doing. Since #3178 is closed and this is a performance change, I suppose it needs a new issue for the changelog, but just to confirm, shall I file one and open a PR? Agreed the per-batch numbers do not establish a whole-query result, and TPC-H does not exercise `array_join`, so that would need a targeted benchmark. Happy to look at it separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
