ShayanGho commented on code in PR #24943:
URL: https://github.com/apache/datafusion/pull/24943#discussion_r3938248112
##########
datafusion/spark/src/function/math/factorial.rs:
##########
@@ -43,7 +47,14 @@ impl Default for SparkFactorial {
impl SparkFactorial {
pub fn new() -> Self {
Self {
- signature: Signature::exact(vec![Int32], Volatility::Immutable),
+ signature: Signature::coercible(
+ vec![Coercion::new_implicit(
Review Comment:
Switched to Coercion::new_implicit_native and removed the NativeType import.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
