comphead commented on PR #5262: URL: https://github.com/apache/datafusion-comet/pull/5262#issuecomment-5547400392
> [The signed-zero tests are skipped](https://github.com/apache/datafusion-comet/blob/f536ca7f9bcd49b1012f2017cdcf67555b38410d/spark/src/test/resources/sql-tests/expressions/array/array_distinct.sql#L139), but array_distinct and array_union remain enabled by default. Spark 4.1.3 returns [0.0, -0.0, 1.0] for the distinct example; DataFusion 55 returns [0.0, 1.0]. I reproduced the difference for both functions. Add compatible evaluation or type/version-aware fallback, then restore the tests. The comment claiming literal inputs are normalized is also incorrect for Spark 4.1. This should not be the case anymore as `[0.0, 1.0]` is the correct answer. Spark should report the same once https://issues.apache.org/jira/browse/SPARK-54918 backported to 4.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
