peterxcli commented on PR #5682: URL: https://github.com/apache/datafusion-comet/pull/5682#issuecomment-5553299686
Addressed the follow-up: - Added the ASCII-class throughput explanation to the description, attributing the benchmark numbers to your measurements, and documented the invariant beside the regexes. - Added `2020-10-1` / `2020-12-1` to the Rust and Scala corpora, negative-year Scala cases, and both Unicode fraction panic examples. Checked slices in both decoders now prevent the boundary panic independently of the regexes; direct decoder tests cover that. - Included `trim_end()` and exact TZ/NTZ regression values for the spaced offset. - Added benchmark shapes for single-digit segments, empty fractions, and rejected date-only zones. - Widened the fuzz alphabet with `-`, `.`, `+`, and `Z`. This exposed a separate positive-year mismatch (`+7528`, etc.), now filed as #5716 and documented in the compatibility guide. Only bare positive years are excluded pending that fix; the wider alphabet stays. Validation: 662 Rust tests passed; `make core`, benchmark compilation, all 77 benchmark smoke cases, Clippy (`-D warnings`), and formatting/style checks passed. The Spark 4.1.3 full cast suite had 169 passes and the one positive-year failure; after excluding that tracked case, all 7 string-to-timestamp tests passed, including both segment-rule suites and the widened fuzz test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
