Xuanwo commented on code in PR #23830:
URL: https://github.com/apache/datafusion/pull/23830#discussion_r3943221860
##########
datafusion/expr/src/logical_plan/builder.rs:
##########
@@ -1018,6 +1024,48 @@ impl LogicalPlanBuilder {
self.asof_join_with_constraint(right, on, match_condition,
JoinConstraint::On)
}
+ /// Apply a left-preserving ASOF join using ordinary `ON` and
+ /// `MATCH_CONDITION` expressions.
+ ///
+ /// Equality predicates may be combined with `AND`. This method validates
+ /// and separates their left and right operands before constructing the
+ /// structured ASOF logical plan.
+ pub fn asof_join_on(
+ self,
+ right: LogicalPlan,
+ on_exprs: impl IntoIterator<Item = Expr>,
Review Comment:
Agreed and updated.
##########
datafusion/expr/src/logical_plan/builder.rs:
##########
Review Comment:
Updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
