haochunchang commented on issue #1169: URL: https://github.com/apache/datafusion/issues/1169#issuecomment-5633254208
Following up here since this has sat open since 2021 with an unresolved design question. ValuesExec no longer exists in the codebase. It was deprecated in favor of MemoryExec (#14032), folded into the unified DataSourceExec/MemorySourceConfig abstraction (#14224), and the standalone values.rs file was deleted outright as part of the v45 deprecation cleanup (#17075). VALUES-list handling now lives in [MemorySourceConfig::try_new_as_values](https://github.com/apache/datafusion/blob/main/datafusion/datasource/src/memory.rs#L377). It still evaluates the literal expressions into a RecordBatch eagerly, at construction time. `execute()/open()` just clones the pre-built batches, and statistics()/partition_statistics() reads from that same eager data. I'd propose to close this issue. Happy to learn for what I have missed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
