peterxcli commented on code in PR #5807:
URL: https://github.com/apache/datafusion-comet/pull/5807#discussion_r3998738674
##########
native/proto/src/proto/operator.proto:
##########
@@ -819,26 +818,25 @@ message RssPartitionWriter {}
message ShuffleWriter {
spark.spark_partitioning.Partitioning partitioning = 1;
// Retained for compatibility with native binaries that predate
partition_writer.
- // Local plans also carry these paths in partition_writer.local.
+ // Local plans also carry this path in partition_writer.local.
string output_data_file = 3;
- string output_index_file = 4;
- CompressionCodec codec = 5;
- int32 compression_level = 6;
- bool tracing_enabled = 7;
+ CompressionCodec codec = 4;
Review Comment:
Thanks for reviewing this. My understanding is that users normally deploy
the released Comet JAR, which bundles the JVM code and its matching native
library. Both protobuf producers and consumers therefore change together. Do we
support any deployment where those components intentionally use different Comet
versions?
With matching builds, removing the fields and renumbering should not affect
runtime correctness. I understand the value of keeping reserved declarations
for consistency and preventing accidental reuse, but I think that is a separate
consideration from supporting older native binaries. Could we clarify that
compatibility requirement and update the existing comment accordingly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
