athlcode commented on code in PR #5876:
URL: https://github.com/apache/datafusion-comet/pull/5876#discussion_r3998814690
##########
spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala:
##########
@@ -486,11 +486,17 @@ case class CometScanRule(session: SparkSession)
// which bucket's per-bucket S3 settings the single native FileIO
consumes (see
// catalogProperties below), so this must run before we build them.
The task list is
// handed to `extract` below so the reflective accessor runs once per
scan.
+ // The task list is cast to `java.util.List[AnyRef]` rather than left
at the
+ // `java.util.List[_]` that `getTasks` returns: a wildcard element
type makes this
+ // pair infer a top-level existential, which `-Xlint:existential`
rejects. The list
+ // is erased at runtime, so the cast costs nothing.
val (icebergTasks, taskValidation) =
try {
IcebergReflection.getTasks(scanExec.scan) match {
case Some(tasks) =>
- (tasks, CometScanRule.validateIcebergFileScanTasks(tasks,
s3CompliantSchemes))
+ (
+ tasks.asInstanceOf[java.util.List[AnyRef]],
Review Comment:
Done in getTasks and its two private helpers, the cast and comment in
CometScanRule are gone.
##########
spark/src/test/scala/org/apache/spark/sql/CometTestBase.scala:
##########
@@ -794,7 +794,7 @@ abstract class CometTestBase
.withType(schema)
// TODO we need to shim this and use withRowGroupSize(Long) with later
parquet-hadoop versions to remove
// the deprecated warning here
- .withRowGroupSize(rowGroupSize.toInt)
+ .withRowGroupSize(rowGroupSize)
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
