sunchao commented on PR #5841: URL: https://github.com/apache/datafusion-comet/pull/5841#issuecomment-5655980034
@andygrove, addressed the three items from your latest review and rebased onto `main` at `451c999632`; the PR is now at `79c161b293` with no merge conflicts. 1. **Maven bootstrap:** preserved the bootstrap in all three moved jobs and both TPC jobs, and corrected the routing comment. The new guard requires an earlier unconditional bootstrap with failures propagated before direct `./mvnw` commands in both Linux workflows. Regression mutations remove, move, condition, or ignore the bootstrap's failure in each of the five jobs. 2. **Hive routing:** `NATIVE_CONSUMERS` now maps caller IDs to all selecting outputs. `spark_4_1` includes both core and Hive, so a Hive-only label starts the native producer. Exact caller, OR-gate, export, and dependency validation remains enforced. Compute and CLI tests cover core-only, Hive-only, both, queue, and manual runs; upstream's module selection is preserved. 3. **Coverage:** applied all four requested labels after pushing this head: `run-spark-3.4-tests`, `run-spark-3.5-tests`, `run-spark-4.0-tests`, and `run-iceberg-tests`. The [regular PR run](https://github.com/apache/datafusion-comet/actions/runs/34781345188) and four additional opt-in runs ([1](https://github.com/apache/datafusion-comet/actions/runs/34781354519), [2](https://github.com/apache/datafusion-comet/actions/runs/34781354752), [3](https://github.com/apache/datafusion-comet/actions/runs/34781354819), [4](https://github.com/apache/datafusion-comet/actions/runs/34781355034)) are pending. This requests coverage of all nine rewired consumers, including the Spark 3.4/JDK 11 setup path; runtime results are not yet confirmed. Local validation passed: 36 configuration regression tests, 21 native-selection tests (299,008 combinations), actionlint, suite/benchmark inventory checks, 15 Iceberg shard tests, 4 PR-label tests, Markdown formatting, and whitespace checks. The PR description now reflects the implementation and pending hosted coverage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
