rluvaton commented on PR #25246:
URL: https://github.com/apache/datafusion/pull/25246#issuecomment-5663858119
I think we should coordinate on that since I have very similar
implementation but mine is more complete and also I already did a lot of
benchmarks on it
+ some decisions I did like:
- emit all should not return single large vec since it:
1. force a copy
2. allow for misuse
3. you want to emit all but in blocks (when spilling for example)
- you should not add block_len on the existing aggregates since the
implementation should be build around the blocked impl
- having the same trait force emit all users to return large array rather
than blocks and no emit block function
and many more
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
