peterxcli commented on code in PR #5928:
URL: https://github.com/apache/datafusion-comet/pull/5928#discussion_r4007867372
##########
spark/src/main/scala/org/apache/spark/sql/comet/operators.scala:
##########
@@ -2797,8 +2797,11 @@ object CometSortMergeJoinExec extends
CometOperatorSerde[SortMergeJoinExec] {
*/
private def supportedSortMergeJoinEqualType(dataType: DataType): Boolean =
dataType match {
case st: StringType if isStringCollationType(st) => false
+ // Spark orders binary by unsigned byte, which is also how Arrow orders
`Binary`, so the
+ // sorted inputs Spark guarantees agree with DataFusion's SMJ key
comparator.
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
