peterxcli opened a new pull request, #5940:
URL: https://github.com/apache/datafusion-comet/pull/5940

   ## Which issue does this PR close?
   
   Part of #4616.
   
   ## Rationale for this change
   
   The `json_array_length` fixtures compare results but do not distinguish 
native execution from JVM codegen dispatch. They also omit fallback coverage 
when the dispatcher is disabled.
   
   ## What changes are included in this PR?
   
   Add a routing test covering native opt-in and dispatcher settings, column 
and literal arguments, NULL, empty arrays, and lenient JSON parsing on the 
default path. Compare results with Spark and check fallback reasons or the 
native projection's expression payload. Inspecting the payload also covers 
Spark 4's `StaticInvoke` rewrite, which does not preserve the expression's 
implementation tags.
   
   ## How are these changes tested?
   
   The targeted `CometCodegenSuite` test and both existing `json_array_length` 
SQL fixtures pass locally on Spark 3.5.9 and 4.1.3 with JDK 17. The new test 
covers 12 query/configuration combinations. `make format` (Spark 3.5) and 
Apache RAT passed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to