github-actions[bot] commented on PR #25337: URL: https://github.com/apache/datafusion/pull/25337#issuecomment-5685274613
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-functions-aggregate v55.1.0 (current) Built [ 32.194s] (current) Parsing datafusion-functions-aggregate v55.1.0 (current) Parsed [ 0.044s] (current) Building datafusion-functions-aggregate v55.1.0 (baseline) Built [ 30.045s] (baseline) Parsing datafusion-functions-aggregate v55.1.0 (baseline) Parsed [ 0.044s] (baseline) Checking datafusion-functions-aggregate v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.262s] 223 checks: 221 pass, 2 fail, 0 warn, 31 skip --- failure function_parameter_count_changed: pub fn parameter count changed --- Description: A publicly-visible function now takes a different number of parameters. ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/function_parameter_count_changed.ron Failed in: datafusion_functions_aggregate::percentile_cont::create_percentile_accumulator now takes 5 parameters instead of 4, in /home/runner/work/datafusion/datafusion/datafusion/functions-aggregate/src/percentile_cont.rs:311 datafusion_functions_aggregate::percentile_cont::create_percentile_groups_accumulator now takes 4 parameters instead of 3, in /home/runner/work/datafusion/datafusion/datafusion/functions-aggregate/src/percentile_cont.rs:360 --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/inherent_method_missing.ron Failed in: ApproxPercentileAccumulator::new, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/0b6ff8a3ef11b7247cc09ac5d3c8dbd3643b29d8/datafusion/functions-aggregate/src/approx_percentile_cont.rs:337 ApproxPercentileAccumulator::new_with_max_size, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/0b6ff8a3ef11b7247cc09ac5d3c8dbd3643b29d8/datafusion/functions-aggregate/src/approx_percentile_cont.rs:345 Summary semver requires new major version: 2 major and 0 minor checks failed Finished [ 64.803s] datafusion-functions-aggregate Building datafusion-sqllogictest v55.1.0 (current) Built [ 92.547s] (current) Parsing datafusion-sqllogictest v55.1.0 (current) Parsed [ 0.023s] (current) Building datafusion-sqllogictest v55.1.0 (baseline) Built [ 92.261s] (baseline) Parsing datafusion-sqllogictest v55.1.0 (baseline) Parsed [ 0.022s] (baseline) Checking datafusion-sqllogictest v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.125s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 187.916s] datafusion-sqllogictest ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
