jayzhan211 commented on PR #25381:
URL: https://github.com/apache/datafusion/pull/25381#issuecomment-5699210788
Thanks @osipovartem , here is a suggestion
The unit tests only call `return_field_from_args` directly. Consider an
end-to-end `.slt` case (e.g. in `test_files/string/string_query.slt.part` or
`functions.slt`) so the planned schema and the outer-join case are covered:
```sql
statement ok
CREATE TABLE case_nullability (a VARCHAR NOT NULL, b VARCHAR) AS VALUES
('Ab', NULL);
statement ok
CREATE TABLE case_nullability_out AS
SELECT upper(a) ua, lower(a) la, upper(b) ub FROM case_nullability;
query TTT
DESCRIBE case_nullability_out;
----
ua Utf8View NO
la Utf8View NO
ub Utf8View YES
query T
SELECT upper(t.a) FROM (SELECT 1 k) x LEFT JOIN case_nullability t ON false;
----
NULL
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
