kosiew commented on PR #25234: URL: https://github.com/apache/datafusion/pull/25234#issuecomment-5712148157
@haohuaijin I agree with option 1. The widening optimization exposes pre-existing interval-bound failures in negation and narrowing casts, and fixing both correctly needs broader boundary coverage than this sort-correctness fix. Please remove the widening change, keep the overflow/division fixes, and update the FIFO and sort expectations. We can track widening separately with targeted tests for those bound transitions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
