kosiew commented on code in PR #25371:
URL: https://github.com/apache/datafusion/pull/25371#discussion_r4036498550
##########
datafusion/physical-plan/src/joins/nested_loop_join.rs:
##########
@@ -3055,8 +3057,7 @@ impl NestedLoopJoinStream {
Vec::with_capacity(filter.column_indices().len());
Review Comment:
Could we add an execution-level regression test that combines a multi-batch
left input, a join filter, and a reordered `NestedLoopJoinExec` projection? The
new `LogicalBatch::take_column` path is now used for both filter columns and
output columns, but the current runtime join tests appear to construct the
executor with `projection: None`, while the existing projection coverage only
checks proto state.
I don't think this needs to block the PR since the unprojected multi-segment
paths and the `LogicalBatch` gather behavior are already well covered, but
having this combination exercised end to end would help protect the new path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
