andygrove commented on PR #4487: URL: https://github.com/apache/datafusion-comet/pull/4487#issuecomment-5719755919
Triage note: native Iceberg V2 writes landed on main in the meantime, via #5298 and then #5361, so `CometIcebergNativeWrite.scala`, `CometIcebergWriteExec.scala` and `native/core/src/execution/operators/iceberg_write.rs` all exist there now with a different implementation. This PR is currently conflicting against main, and it overlaps nine files with #5724 alone, plus #5935 and #5957 on the same write path. @jordepic, thank you for this, and for the benchmarks — they are a good part of what convinced us the native write path was worth having. Is there anything left here that main does not cover? If so it would be much easier to review as a small PR on top of what merged. If not, I think this should be closed with a pointer to #5649, which tracks the remaining production-quality work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
