jordepic commented on PR #5724: URL: https://github.com/apache/datafusion-comet/pull/5724#issuecomment-5719835828
Hey all, revisiting this one. After doing my initial claude-slop review pass on the query, I think we find ourselves moreso with a philosophical question than anything. Inherently iceberg-rs relies on too many libraries with subtle differences (e.g. parquet) between rust and java. It's impossible to be completely perfect, byte for byte. In my opinion, this is the type of feature where we whitelist everything that is provably equivalent, and then provide an opt-in toggle for the things that aren't so that Datadog can still use its bloom filters -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
