Himanshu-2005-code commented on issue #25419: URL: https://github.com/apache/datafusion/issues/25419#issuecomment-5721239726
Sorry Sir, I hadn't seen you'd already opened a fix when I asked to be assigned. Reviewed #25431: pulled the branch, built it, and ran the datafusion-spark test suite plus the two updated .slt files — all pass, and cargo clippy is clean. The fix looks correct to me — it slices flat_keys down to the current row range before filtering, so the mask lines up with the values it's applied against. I also checked the FixedSizeList/LargeList cases specifically (arrow-rs re-bases FixedSizeListArray::values() on slice already, so the fix's assumptions hold there too), and the new unit tests cover the LAST_WIN and null-row interactions well. Nothing I'd change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
