dwsmith1983 commented on PR #5874: URL: https://github.com/apache/datafusion-comet/pull/5874#issuecomment-5732018990
> Could you two agree the ordering? Agreed on that split. This PR lands `length` natively through `SparkLengthFunc`, and #5607 keeps `bit_length` and `octet_length` with the benchmark and the note on why the dispatcher is not worth it there. The `length.sql` binary cases here assert native, so #5607 would drop its `expect_fallback` line for `length` and keep the other two fixtures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
