alamb commented on code in PR #25536:
URL: https://github.com/apache/datafusion/pull/25536#discussion_r4065767785
##########
datafusion/expr/src/udaf.rs:
##########
@@ -311,6 +312,17 @@ impl AggregateUDF {
self.inner.simplify()
}
+ /// Returns this aggregate function's candidate decomposition, if any.
+ ///
+ /// See [`AggregateUDFImpl::decompose`] for more details.
+ pub fn decompose(
Review Comment:
> If implemented in simplify, every AVG would be unconditionally rewritten
into SUM/COUNT.
Given the internal avg implementation basically has a sum and count
accumulator, I am surprised at these numbers. Can you profile them and find out
why there is a performance difference?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
