github-actions[bot] commented on PR #25150: URL: https://github.com/apache/datafusion/pull/25150#issuecomment-5776234414
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-common v55.0.0 (current) Built [ 24.140s] (current) Parsing datafusion-common v55.0.0 (current) Parsed [ 0.046s] (current) Building datafusion-common v55.1.0 (baseline) Built [ 24.461s] (baseline) Parsing datafusion-common v55.1.0 (baseline) Parsed [ 0.047s] (baseline) Checking datafusion-common v55.1.0 -> v55.0.0 (minor change) Checked [ 0.479s] 196 checks: 194 pass, 2 fail, 0 warn, 58 skip --- failure function_missing: pub fn removed or renamed --- Description: A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/function_missing.ron Failed in: function datafusion_common::utils::offset_span, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d942a43a7cb81984f010ff2d9cd45b075514c904/datafusion/common/src/utils/mod.rs:1255 function datafusion_common::utils::offset_span_len, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d942a43a7cb81984f010ff2d9cd45b075514c904/datafusion/common/src/utils/mod.rs:1237 function datafusion_common::utils::has_float_leaf, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d942a43a7cb81984f010ff2d9cd45b075514c904/datafusion/common/src/utils/mod.rs:1527 --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/inherent_method_missing.ron Failed in: FieldMetadata::to_metadata, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d942a43a7cb81984f010ff2d9cd45b075514c904/datafusion/common/src/metadata.rs:306 Summary semver requires new major version: 2 major and 0 minor checks failed Finished [ 51.002s] datafusion-common Building datafusion-physical-plan v55.0.0 (current) Built [ 27.621s] (current) Parsing datafusion-physical-plan v55.0.0 (current) Parsed [ 0.115s] (current) Building datafusion-physical-plan v55.1.0 (baseline) Built [ 27.673s] (baseline) Parsing datafusion-physical-plan v55.1.0 (baseline) Parsed [ 0.128s] (baseline) Checking datafusion-physical-plan v55.1.0 -> v55.0.0 (minor change) Checked [ 0.476s] 196 checks: 194 pass, 2 fail, 0 warn, 58 skip --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/inherent_method_missing.ron Failed in: RepartitionExec::with_batch_size, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d942a43a7cb81984f010ff2d9cd45b075514c904/datafusion/physical-plan/src/repartition/mod.rs:2242 LimitedBatchCoalescer::push_batch_with_filter, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d942a43a7cb81984f010ff2d9cd45b075514c904/datafusion/physical-plan/src/coalesce/mod.rs:128 AsOfJoinExec::with_projection, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d942a43a7cb81984f010ff2d9cd45b075514c904/datafusion/physical-plan/src/joins/asof_join.rs:256 AsOfJoinExec::try_from_proto, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d942a43a7cb81984f010ff2d9cd45b075514c904/datafusion/physical-plan/src/joins/asof_join.rs:669 ChildFilterDescription::from_child_with_column_mapping, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d942a43a7cb81984f010ff2d9cd45b075514c904/datafusion/physical-plan/src/filter_pushdown.rs:468 --- failure trait_method_receiver_mut_ref_became_ref: trait method receiver changed from mutable to immutable reference --- Description: A method in an unsealed trait now takes &self instead of &mut self, breaking downstream implementations. ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-item-signature impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/trait_method_receiver_mut_ref_became_ref.ron Failed in: datafusion_physical_plan::aggregates::group_values::multi_group_by::GroupColumn::vectorized_equal_to now takes &Self, not &mut Self, in /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/aggregates/group_values/multi_group_by/mod.rs:91 Summary semver requires new major version: 2 major and 0 minor checks failed Finished [ 57.212s] datafusion-physical-plan ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
