gstamatakis95 commented on code in PR #25279:
URL: https://github.com/apache/datafusion/pull/25279#discussion_r4076245815
##########
datafusion/datasource/src/file_scan_config/mod.rs:
##########
@@ -617,54 +615,15 @@ impl From<FileScanConfig> for FileScanConfigBuilder {
}
}
-/// Builds `Partitioning::Hash` over `partition_cols` (resolved to their
indices in
-/// `schema`). Returns `None` when there are no partition columns.
-///
-/// # Deprecated
-/// Use [`range_partitioning_from_partition_fields`] instead.
-#[deprecated(
- since = "56.0.0",
- note = "Hive file groups are value partitioned, not hash partitioned. Use
range_partitioning_from_partition_fields"
-)]
+/// Builds output partitioning over `partition_cols` (resolved to their
indices in
+/// `schema`) with `partition_count` partitions. Returns `None` when there are
no
+/// partition columns. Callers use this to declare the output partitioning of
a scan
+/// whose file groups are organized by partition column values.
pub fn output_partitioning_from_partition_fields(
schema: &Schema,
partition_cols: &Fields,
partition_count: usize,
) -> Option<Partitioning> {
Review Comment:
Deprecated it in favor of `output_range_partitioning_from_split_points` with
the signature you suggested and `ListingTable::scan` now uses it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
