alamb commented on code in PR #25608:
URL: https://github.com/apache/datafusion/pull/25608#discussion_r4081895313
##########
datafusion/datasource-parquet/src/sort.rs:
##########
@@ -18,109 +18,10 @@
//! Sort-related utilities for Parquet scanning
use arrow::datatypes::Schema;
-use datafusion_common::{Result, ScalarValue};
+use datafusion_common::ScalarValue;
use datafusion_datasource::PartitionedFile;
use datafusion_physical_expr::expressions::Column;
use datafusion_physical_expr_common::sort_expr::LexOrdering;
-use parquet::arrow::arrow_reader::{RowSelection, RowSelector};
-use parquet::file::metadata::ParquetMetaData;
-use std::collections::HashMap;
-
-/// Reverse a row selection to match reversed row group order.
Review Comment:
the idea here is we don't need to reverse selection anymore because the
selections are already done per-row group and thus they don't need to be
resplit, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
