LucaCappelletti94 commented on code in PR #2482:
URL: 
https://github.com/apache/datafusion-sqlparser-rs/pull/2482#discussion_r4097577189


##########
.tool-versions:
##########
@@ -1 +1 @@
-rust 1.75.0
\ No newline at end of file
+rust 1.88.0

Review Comment:
   The `.tool-versions` bump leaves the crate's MSRV untouched. The crate 
declares no `rust-version` in `Cargo.toml` (maybe we should), so cargo enforces 
no MSRV for downstream users, and downstream builds resolve their own 
dependency graph without reading our `Cargo.lock`. CI does not read 
`.tool-versions` either.
   
   The file only selects the toolchain that `asdf` and `mise` install for local 
development in this checkout.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to