alamb commented on code in PR #25687: URL: https://github.com/apache/datafusion/pull/25687#discussion_r4097613440
########## datafusion/sqllogictest/test_files/aggregate.slt: ########## @@ -5161,6 +5161,27 @@ statement ok drop table bit_distinct; +# A NULL-typed bitwise aggregate with GROUP BY has no integer groups +# accumulator, so it must fall back to the scalar accumulator instead of Review Comment: I think this comment is about the implementation which will be outdated when we merge this in Can you please just change the comment with what it is testing (NULL inputs with bitwise aggregates)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
