dwsmith1983 commented on code in PR #5654:
URL: https://github.com/apache/datafusion-comet/pull/5654#discussion_r4100208405
##########
spark/src/test/scala/org/apache/comet/parquet/ParquetReadSuite.scala:
##########
@@ -2109,6 +2221,76 @@ abstract class ParquetReadSuite extends CometTestBase {
assert(
cause.isInstanceOf[RuntimeException] &&
cause.getMessage.contains("Found duplicate field(s)"))
+ checkDuplicateFieldIdMessage(
+ spark.read.schema(readSchema).parquet(dir.getCanonicalPath),
+ """"1": [a, rand2]""")
+ }
+ }
+ }
+
+ test("duplicate exact nested names are refused when requested and skipped
otherwise") {
Review Comment:
Nothing about the pyarrow writer mattered, the file only gave the two reads
a nested duplicate name. The test and `duplicate-nested-names.parquet` are
gone. `CometNativeReaderSuite` covers both reads on `main` with a file written
from `named_struct`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
