osipovartem commented on code in PR #2489:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2489#discussion_r4103697967
##########
tests/sqlparser_snowflake.rs:
##########
@@ -4954,6 +4954,85 @@ fn test_structured_array_type() {
);
}
+#[test]
+fn test_structured_object_type() {
+ snowflake_and_generic().verified_stmt(
+ "SELECT payload::OBJECT(address OBJECT(city VARCHAR NOT NULL), zip
NUMBER) FROM t",
+ );
+ snowflake()
+ .verified_stmt("SELECT payload::OBJECT(tags ARRAY, labels MAP(VARCHAR,
VARCHAR)) FROM t");
+ let select = snowflake().verified_only_select(
+ "SELECT payload::OBJECT(items ARRAY(NUMBER NOT NULL), meta
MAP(VARCHAR, OBJECT(k NUMBER) NOT NULL)) FROM t",
+ );
+ let Expr::Cast { data_type, .. } =
expr_from_projection(only(&select.projection)) else {
+ unreachable!();
+ };
+ let DataType::Object(fields) = data_type else {
+ unreachable!();
+ };
+ assert!(matches!(
+ &fields[0].data_type,
+ DataType::Array(ArrayElemTypeDef::ParenthesisNotNull(_))
+ ));
+ let DataType::Map(
+ _,
+ value,
+ MapBracketKind::SnowflakeParentheses {
+ value_not_null: true,
+ },
+ ) = &fields[1].data_type
+ else {
Review Comment:
Updated the test to match `ParenthesesNotNull` (67c962b6).
##########
tests/sqlparser_snowflake.rs:
##########
@@ -4954,6 +4954,85 @@ fn test_structured_array_type() {
);
}
+#[test]
+fn test_structured_object_type() {
+ snowflake_and_generic().verified_stmt(
+ "SELECT payload::OBJECT(address OBJECT(city VARCHAR NOT NULL), zip
NUMBER) FROM t",
+ );
+ snowflake()
+ .verified_stmt("SELECT payload::OBJECT(tags ARRAY, labels MAP(VARCHAR,
VARCHAR)) FROM t");
+ let select = snowflake().verified_only_select(
+ "SELECT payload::OBJECT(items ARRAY(NUMBER NOT NULL), meta
MAP(VARCHAR, OBJECT(k NUMBER) NOT NULL)) FROM t",
+ );
+ let Expr::Cast { data_type, .. } =
expr_from_projection(only(&select.projection)) else {
+ unreachable!();
+ };
+ let DataType::Object(fields) = data_type else {
+ unreachable!();
+ };
+ assert!(matches!(
+ &fields[0].data_type,
+ DataType::Array(ArrayElemTypeDef::ParenthesisNotNull(_))
+ ));
+ let DataType::Map(
+ _,
+ value,
+ MapBracketKind::SnowflakeParentheses {
+ value_not_null: true,
+ },
+ ) = &fields[1].data_type
+ else {
+ unreachable!();
+ };
+ assert!(matches!(**value, DataType::Object(_)));
+
+ snowflake().one_statement_parses_to(
+ "SELECT payload::ARRAY(NUMBER) FROM t",
+ "SELECT payload::Array(NUMBER) FROM t",
+ );
+ snowflake().verified_stmt("SELECT payload::MAP(VARCHAR, OBJECT(k NUMBER))
FROM t");
Review Comment:
Updated this case to expect `Map(...)` (67c962b6).
##########
tests/sqlparser_snowflake.rs:
##########
@@ -4954,6 +4954,85 @@ fn test_structured_array_type() {
);
}
+#[test]
+fn test_structured_object_type() {
+ snowflake_and_generic().verified_stmt(
+ "SELECT payload::OBJECT(address OBJECT(city VARCHAR NOT NULL), zip
NUMBER) FROM t",
+ );
+ snowflake()
+ .verified_stmt("SELECT payload::OBJECT(tags ARRAY, labels MAP(VARCHAR,
VARCHAR)) FROM t");
+ let select = snowflake().verified_only_select(
+ "SELECT payload::OBJECT(items ARRAY(NUMBER NOT NULL), meta
MAP(VARCHAR, OBJECT(k NUMBER) NOT NULL)) FROM t",
+ );
+ let Expr::Cast { data_type, .. } =
expr_from_projection(only(&select.projection)) else {
+ unreachable!();
+ };
+ let DataType::Object(fields) = data_type else {
+ unreachable!();
+ };
+ assert!(matches!(
+ &fields[0].data_type,
+ DataType::Array(ArrayElemTypeDef::ParenthesisNotNull(_))
+ ));
+ let DataType::Map(
+ _,
+ value,
+ MapBracketKind::SnowflakeParentheses {
+ value_not_null: true,
+ },
+ ) = &fields[1].data_type
+ else {
+ unreachable!();
+ };
+ assert!(matches!(**value, DataType::Object(_)));
+
+ snowflake().one_statement_parses_to(
+ "SELECT payload::ARRAY(NUMBER) FROM t",
+ "SELECT payload::Array(NUMBER) FROM t",
+ );
+ snowflake().verified_stmt("SELECT payload::MAP(VARCHAR, OBJECT(k NUMBER))
FROM t");
+ snowflake().verified_stmt("SELECT payload::ARRAY(NUMBER NOT NULL) FROM t");
+ snowflake().verified_stmt("SELECT payload::MAP(VARCHAR, NUMBER NOT NULL)
FROM t");
+ snowflake_and_generic().verified_stmt("CREATE TABLE t (o OBJECT())");
+
+ let select = snowflake().verified_only_select(
+ "SELECT CAST(payload AS OBJECT(city VARCHAR, zip NUMBER NOT NULL))
FROM t",
+ );
+ let Expr::Cast { data_type, .. } =
expr_from_projection(only(&select.projection)) else {
+ unreachable!();
+ };
+ let DataType::Object(fields) = data_type else {
+ unreachable!();
+ };
+ assert_eq!(fields.len(), 2);
+ assert_eq!(fields[0].name, Ident::new("city"));
+ assert!(fields[0].options.is_empty());
+ assert_eq!(fields[1].name, Ident::new("zip"));
+ assert_eq!(fields[1].options.len(), 1);
+ assert_eq!(fields[1].options[0].option, ColumnOption::NotNull);
+
+ for sql in [
+ "CREATE TABLE t (o OBJECT(VARCHAR))",
+ "CREATE TABLE t (o OBJECT('json'))",
+ "CREATE TABLE t (o OBJECT('city' VARCHAR))",
+ "CREATE TABLE t (o OBJECT(city VARCHAR NULL))",
+ "CREATE TABLE t (o OBJECT(city VARCHAR)",
+ ] {
+ assert!(snowflake().parse_sql_statements(sql).is_err(), "{sql}");
+ }
Review Comment:
Kept only the unterminated error case (67c962b6).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
