sunchao commented on code in PR #5027:
URL: https://github.com/apache/datafusion-comet/pull/5027#discussion_r4105245129
##########
spark/src/main/scala/org/apache/comet/udf/codegen/CometScalaUDFCodegen.scala:
##########
@@ -87,7 +88,10 @@ class CometScalaUDFCodegen extends CometUDF with Logging {
: mutable.Map[CometScalaUDFCodegen.CacheKey,
CometScalaUDFCodegen.CacheEntry] =
mutable.HashMap.empty
- override def evaluate(inputs: Array[ValueVector], numRows: Int): ValueVector
= {
+ override def evaluate(
+ allocator: BufferAllocator,
Review Comment:
[P1] Update both benchmark callers when adding the allocator parameter.
`CometTimeExtractBenchmark.scala` still calls `dispatcher.evaluate(inputs,
size)` at lines 122 and 149. With the default Spark 4.1 profile, test
compilation now fails instead of compiling those calls, preventing every Linux
JVM test group and both TPC verification jobs from running. Please pass
`CometArrowAllocator` at both sites, as the updated direct call in
`CometCodegenSuite` does, then rerun test compilation and the focused suites.
Evidence: Exact-head CI run 35170049560 checks out the merge of
dc117b0135659137591e26e84edd87ee1a387e03 into
36146a87bf9ca9ca9e211b4372628ed2f9d8c8c6. The expressions job reports `not
enough arguments for method evaluate` and `Unspecified value parameter numRows`
at CometTimeExtractBenchmark.scala:122 and :149, then fails
`scala-maven-plugin:4.9.6:testCompile`. The same errors occur in the exec,
scans, shuffle, TPC-H and TPC-DS jobs. Source comparison confirms the callers
are unchanged while the two-argument method was replaced by this three-argument
signature.
https://github.com/apache/datafusion-comet/actions/runs/35170049560/job/105040966472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
