liupoyi-1031 commented on code in PR #6216:
URL: https://github.com/apache/datafusion-comet/pull/6216#discussion_r4110096808
##########
spark/src/main/scala/org/apache/comet/serde/operator/CometIcebergNativeWrite.scala:
##########
@@ -217,6 +218,23 @@ object CometIcebergNativeWrite extends
CometOperatorSerde[IcebergWriteExec] {
if (ctx.properties.contains(key)) Some(s"$key is set ($reason)") else
None
}
+ // The property rule above only sees providers configured through
table/write properties. A
+ // custom TableOperations can return a LocationProvider directly, while the
native writer always
+ // generates `<data location>/<partition path>/<file>`. Admit only Iceberg's
default provider;
+ // object-storage layout is already declined by the preceding property rule.
Review Comment:
Thanks for the review. I’ve updated the code comment with the Iceberg 1.11
compatibility context while keeping the fallback unconditional, and updated the
contributor guide to use the explicit rule names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
