kumarUjjawal commented on code in PR #25793: URL: https://github.com/apache/datafusion/pull/25793#discussion_r4115496965
########## datafusion/common/src/hash_utils.rs: ########## Review Comment: One optional test improvement: add two nullable string children to the new regression test. This would directly verify that successive masking passes preserve each other’s hashes in the shared buffer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
