Weijun-H commented on PR #25565:
URL: https://github.com/apache/datafusion/pull/25565#issuecomment-5863273880
Thanks for the detailed review! @andygrove Addressed all five points:
1. Restored fixed-width batch sizes, with matching reservations and a
smaller target when memory is tight.
2. Matched spill targets to Arrow interleave allocation estimates.
3. Restored exact batch and metric assertions.
4. Replaced repeated variable-width prefix scans with incremental
accumulation, preserving the fixed-width fast path.
5. Removed post-allocation reservation growth; estimation failures now fail
before allocation.
Also addressed the nits and documented the stricter memory-accounting
behavior. Ready for another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
