LucaCappelletti94 commented on issue #1807: URL: https://github.com/apache/datafusion-sqlparser-rs/issues/1807#issuecomment-5871597638
When I wrote the issue a while back I had checked it, but now I did not recall anymore and so I started an opus investigation which matches my recollection of it. Here is its summary: The test came from ivanceras in #20 (commit 78c054ea, 2018). In that first version the SQL ended with `INHERITS (system.record)`, which the parser of the time silently ignored because it stopped after the closing parenthesis. A week later, the refactor in 5abd9e7 (same PR) turned the test into a `to_string()` round trip, and the `INHERITS` clause was dropped because the AST could not render it. The name outlived the clause it was about. `INHERITS` itself has been covered since #1806 by `parse_create_table_with_inherits`, and the column features the old SQL still exercised (`TEXT[]`, `BOOLEAN DEFAULT true`, `DEFAULT ... NOT NULL`) are covered by `parse_create_table_from_pg_dump` and the array DDL tests, so #2595 lost no coverage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
