dwsmith1983 commented on PR #6336: URL: https://github.com/apache/datafusion-comet/pull/6336#issuecomment-5881696182
> Could those two passages call out the shuffle writer's zstd context as the exception, alongside the list this PR already updates higher up in the same tuning page? Done in 0d23cb4. The "Non-Rust allocations" bullet in `memory_management.md` now says the pool tracks such memory only where an operator charges it by hand, and names the multi-partition shuffle writer's zstd context as the one case today, in `reserved` and never in `allocated`. Step 3 of the sizing section in `tuning/memory.md` says the same, and that the `allocated - reserved` difference understates what has to fit in the overhead by one context per such task, with the two sizes you gave. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
