yiaany commented on PR #24792: URL: https://github.com/apache/datafusion/pull/24792#issuecomment-5895440362
> Thank you @yiaany > > I apologize for the delay in reviewing. I was struggling to find enough time to write a proper response. > > At a high level, I think this PR is too complicated for what it is doing-- which is probably my fault for not defining it more specifically. I apologize for not being clear > > I was hoping: > > 1. a static version list (you have it in versions.json I think) > 2. documentation of how old versions are published as part of the release process > > I don't think we need to change the current CI for publishing / building documentation > > Then I was imagining we test it locally like: > > 1. manually build docs for a few versions (55.1.0 and 55.0.0 for example) and make a PR to the [asf-site](https://github.com/apache/datafusion/tree/asf-site) branch with the proposed layouts > 2. Build the docs from this PR > 3. Check out [asf-site](https://github.com/apache/datafusion/tree/asf-site) branch manually > 4. move the manually built docs from the PR and put the versioned docs in the right plce > > If that looks good we could merge this main PR and I think the main docs site would be updated. > > I am not sure how much value all the various python test scripts add. If you think they are important, we should document clearly their intent and what types of regressions / breakages they protect again > > > Could a maintainer confirm which bootstrap procedure should be used? > > I suggest Build older site versions one statically / part of the release process (not via a CI action) > > Finally, this might be easier to test if you setup your fork so it published your forks `asf-site` branch as a github pages, and then test out the code / picker there. That would also make it easy for other reviewers to test it out / see what it looks like Hi @alamb, thank you for the detailed review. You were right: I made the first version too complicated. I’ve simplified #24792 to a static version list, the PyData version picker, and instructions for building and publishing release docs manually. I removed the custom build, deployment, validation, and test scripts. The existing docs CI and publishing workflow are unchanged in this PR. I built the docs from the 55.0.0 and 55.1.0 tags and tested the version picker and missing-page fallback locally in a browser. The proposed generated layout is in #25881. I also found that the current deployment’s rsync --delete would remove manually published release docs. I put the one-line fix in a separate PR, #25880. That change needs to land before the snapshots are published. I haven’t set up a public GitHub Pages preview yet. Could you take another look at the smaller approach and let me know whether this matches what you had in mind? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
