andygrove commented on PR #5505: URL: https://github.com/apache/datafusion-comet/pull/5505#issuecomment-5911899802
#6261 has merged and closes #5504, so I think this one can be closed. Before the final metrics are flushed, `releasePlan` now aborts the producer, takes its stream and drops it on the Spark task thread, which covers the ordering problem this PR fixes. It then waits for the plan's reservations to come back. A bounded wait for the cancellation alone wasn't enough, because a producer that is merging spill files can hold its memory past the 100 ms budget. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
