comphead commented on code in PR #6314:
URL: https://github.com/apache/datafusion-comet/pull/6314#discussion_r4146849837
##########
spark/src/test/scala/org/apache/spark/sql/comet/CometTaskMetricsSuite.scala:
##########
@@ -1097,6 +1097,39 @@ class CometTaskMetricsSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
+ test("native block without a JVM input publishes SQL metrics on the update
interval") {
Review Comment:
Nit: the name says this publishes on the update interval, but the body only
covers the disabled interval. It would also pass if this branch never published
mid-stream. Would it make sense to add a case with `"1"` and a short sleep
before the first `batches.next()`, asserting `outputRows.value > 0` afterwards?
I haven't run this, so please skip it if it turns out flaky.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
