jayzhan211 commented on issue #11629:
URL: https://github.com/apache/datafusion/issues/11629#issuecomment-2313763361
What you need to do is, add a new method `reverse_name`
```rust
trait AggregateUDFImpl {
fn reverse_name(&self) -> String {
...
}
}
```
Replace with the code here
```rust
let mut name = self.name().to_string();
// If the function is changed, we need to reverse order_by
clause as well
// i.e. First(a order by b asc null first) -> Last(a order
by b desc null last)
if self.fun().name() == reverse_udf.name() {
} else {
replace_order_by_clause(&mut name);
}
replace_fn_name_clause(&mut name, self.fun.name(),
reverse_udf.name());
```
if the function name is changed (i.e. First -> Last), order by clause
required to rewrite too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
