andygrove commented on PR #6457: URL: https://github.com/apache/datafusion-comet/pull/6457#issuecomment-5917125638
Added `benches/min_max.rs` and `benches/greatest_least.rs` in b15afcfec, and the description now points to them. Before timing, each checks that Comet and DataFusion return the same values on the inputs without NaNs, and the `min_max` module docs say why the grouped case is the one that cannot vectorize. On an M3 Max they match the description within noise: ungrouped `max` 3.3 µs against 5.3 µs, `max` into 1024 groups 32.0 µs against 24.1 µs (43.4 µs for DataFusion with 10% NaN), and `greatest` of three columns 3.9 µs against 37.0 µs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
