parthchandra commented on PR #6461:
URL:
https://github.com/apache/datafusion-comet/pull/6461#issuecomment-5919289525
-
**`spark/src/test/resources/sql-tests/expressions/string/reverse_binary.sql:31`**
— the point of this PR is that binary reverse stays in the Comet pipeline via
the codegen dispatcher, and the fixture's own comment says so, but the query
uses plain `query`. The SQL-file-test doc recommends `query
expect_dispatch(<name>)` for exactly this. Suggest changing the last block to:
query expect_dispatch(reverse)
SELECT reverse(b) FROM test_reverse_binary
Plain `query` already asserts the projection didn't fall back to Spark, so
the fix isn't untested, but `expect_dispatch` turns the comment's claim into a
real assertion and guards against a future native binary path that diverges.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
