zhangfengcdt commented on code in PR #6493:
URL: https://github.com/apache/datafusion-comet/pull/6493#discussion_r4151933723
##########
spark/src/test/scala/org/apache/comet/CometSparkSessionExtensionsSuite.scala:
##########
@@ -114,6 +114,28 @@ class CometSparkSessionExtensionsSuite extends
CometTestBase {
}
}
+ test("reloading NativeBase does not load a second copy of the native
library") {
+ // The bundled library is unpacked to a new temporary file each time it is
loaded. To the JVM
+ // a second copy is a distinct library with its own uninitialized native
state, and a JNI
+ // method first called afterwards can bind to it (#6096).
+ def unpackedLibraries(): Set[String] =
Review Comment:
Sure! It should be fixed now. It now compares the path of the library before
and after a reload and asserts it is the same object. It no longer reads the
temp directory at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
