alamb commented on code in PR #25696:
URL: https://github.com/apache/datafusion/pull/25696#discussion_r4154454893
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -1383,7 +1383,7 @@ impl AggregateExec {
/// Set a legacy limit hint. Unsupported requests leave ordinary
aggregation.
#[deprecated(
since = "56.0.0",
- note = "This API is intended for internal use only and was
inadvertently made public. Do not use this API."
+ note = "The replacement APIs are
[`try_optimize_topk`](Self::try_optimize_topk) and
[`try_optimize_distinct_soft_limit`](Self::try_optimize_distinct_soft_limit).
They still require specific plan-shape invariants to be used correctly, so they
remain internal for now. If you have a use case that requires these APIs to be
public, please open an issue in DataFusion."
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
