dwsmith1983 commented on PR #25656: URL: https://github.com/apache/datafusion/pull/25656#issuecomment-5943055554
Thanks for kicking off the run. It doesn't show the gains I measured locally: the benchmarks I cited are flat to slightly slower here, and the logical-only groups that never reach this code moved by about the same amount, so on this hardware the change is at best neutral. I don't think it's worth the added logic without a measurable win, so I'll close this. Happy to split out the `logically_equivalent_names_and_types` identity shortcut on its own if you'd still like it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
