dwsmith1983 commented on PR #25658: URL: https://github.com/apache/datafusion/pull/25658#issuecomment-5952501082
@jayzhan211 thanks, nice find. You're right that the scan for `-0.0` runs over the whole build column each time the comparator is built, even when nothing needs rewriting. I'd like to keep this PR to what it has and do the build-time normalization in a follow-up: store the normalized keys in `JoinLeftData` beside `values()`, account for any copy in the build reservation, and add a constructor that takes pre-normalized left arrays. I'll use your query as the benchmark. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
