dwsmith1983 commented on PR #6270: URL: https://github.com/apache/datafusion-comet/pull/6270#issuecomment-5996587509
> Could you update that paragraph to describe both? Updated in da0a37921. The paragraph now says `doCanonicalize` strips every DPP filter from the stale `originalPlan` copy, and that the scan's DPP identity comes from the top-level `partitionFilters`, where `filterUnusedDynamicPruningExpressions` drops only `DynamicPruningExpression(TrueLiteral)`, as `FileSourceScanExec` does. It points a new scan at that second rule and says why: a filter that still holds the adaptive broadcast placeholder has to stay, because AQE canonicalizes a query stage as its exchange was before the placeholder was converted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
